Revision 7f3e9060d1430f3848e58ce8822def129d2d25f0
Committed on 30/11/2020 1:09 am by
JAC - Frederic Bauer <frederic.bauer@jac-systeme.de> [GitHub Diff]
Safety commit before refactoring the bundle:
Reworked the favourite-functionality and added specific routes, functions and more to facilitate that new behaviour
PHP:
- ConfigProcessController.php:
1. Some smaller refactorings of the internal functions to make them more readable and better to use
2. Reworked the set and remove and get favourite functions to facilitate their new behaviour, where favourites are added and removed in a singular fashion
- Utility.php:
1. Some refactorings for improved readability
2. Added function to remove an entry from a hierarchical associative array through a list of key segments, leading to the level from which to remove an entry
- ConfigProcessCoordinator.php: Small refactoring for better readability and removed every function working with favourites (in order to achieve better code separation and make for a more consistent structure overall)
- CustomParamProcessor.php simply renamed the class so it describes it purpose better (as it serves for custom favourites as well as normal custom parameters)
- FavouritesParamCoordinator.php: Has been added to handle all functionality related to the favourites being added or removed or retrieved
config:
- routing.yaml received an additional route for specifically removing a parameter from the favourites, this is now required, as favourites are no longer overwritten but instead appended to the list
JS:
- FavourButtonUtility.js has been reworked to allow favourites to be added or removed as soon as the favourite-button is being clicked
- app.js: Removed an influence of the FavouriteHandlingUtility as its job is now mostly being taken over by the FavourButtonUtility.js
views:
- removed global favour commit buttons from every template as its function is now no longer supported