Path

projects / org / ezproject2010 / ezyui / forum / general / bug path of ezyui incompati...

BUG path of ezyui incompatible with ezpacker

You need to be logged in to post messages in the forums. New users may register here.

Björn X

Member since:
09 January 2008

Posts: 36

Monday 20 July 2009 9:55:20 am

rename

http://svn.projects.ez.no/ezyui/trunk/ezyui/design/standard/lib/

to

http://svn.projects.ez.no/ezyui/trunk/ezyui/design/standard/javascript/

This line of the packer breaks my neck.

$packedFiles = eZYuiPacker::packFiles( $scriptFiles, 'javascript/', '.js', $packLevel, $wwwInCacheHash );

If you move it you also don`t need the additional rw rule.

Looking for hosting? http://hostingezpublish.com
-----------------------------------------------------------------------------
Up

Łukasz Serwatka

Member since:
10 January 2008

Posts: 28

Monday 20 July 2009 3:14:52 pm

I would keep files where are now. As it is more logical to keep it in the lib directory as in the javascript. YUI is not only the JS files, but also CSS, images which are part of default skin for controls. Serving them from javascript directory is a bit weird. This should be fixed in packer IMHO.

Personal website -> http://serwatka.net
Blog (about eZ Publish) -> http://serwatka.net/blog
Up

Björn X

Member since:
09 January 2008

Posts: 36

Tuesday 21 July 2009 6:39:02 am

In this case we definitly need to fix the packer.

I might supply a patch when I have more time.

Looking for hosting? http://hostingezpublish.com
-----------------------------------------------------------------------------
Up

André R.

Member since:
14 January 2008

Posts: 145

Tuesday 21 July 2009 1:28:07 pm

Or we can move scripts to javascript dir, css to stylesheets dir and images to images dir?

eZ Online Editor 5.1: http://projects.ez.no/ezoe || eZJSCore 1.1(Ajax): http://projects.ez.no/ezjscore || eZSearch++(better search results): http://projects.ez.no/ezsearchpro
@: http://twitter.com/andrerom
Up

Björn X

Member since:
09 January 2008

Posts: 36

Wednesday 22 July 2009 4:27:05 pm

I would not rip it apart... people used top the yui might get confused...

Looking for hosting? http://hostingezpublish.com
-----------------------------------------------------------------------------
Up

André R.

Member since:
14 January 2008

Posts: 145

Tuesday 28 July 2009 1:37:39 am

Hi again!

Thanks for fixing a couple of things, however, it would be nice to review your patches before you commit them.
For instance you shouldn't do several things at once in a commit, and the "- added charset parameter to operators" will break any use of the operators that use the last param. Not a big deal as ezyui isn't even at the beta stage and will see some changes, but you really need to discuss this with the other members of the project, so they know about it..

And I'm not convinced the patch for the lib problem is the correct one, it might be better to allow full (design) path if it starts with '/' for instance(see bellow patch), what do you think?

We need to make this as general as possible, just like eZ Publish, so we can't commit workaround code.

Sorry for bringing this up, but as we are a team, we really need to be able to review and discuss, especially patches.

All in sense of better co-operation in future :)

eZ Online Editor 5.1: http://projects.ez.no/ezoe || eZJSCore 1.1(Ajax): http://projects.ez.no/ezjscore || eZSearch++(better search results): http://projects.ez.no/ezsearchpro
@: http://twitter.com/andrerom
Up

You need to be logged in to post messages in the forums. New users may register here.