Code review of eZ4/php5 version & patches
You need to be logged in to post messages in the forums. New users may register here.
|
Bruce Morrison
Member since:
09 January 2008
Posts: 37
|
Tuesday 26 February 2008 5:30:56 pm
Howdy
I've installed the eZ4 /php5 version and am doing a code review as we are going to use this in a project.
Will provide patches/commits (if added as a member)...here's the first one
Index: classes/ezxapprovestatususerlink.php
|
|
|
Bruce Morrison
Member since:
09 January 2008
Posts: 37
|
Wednesday 27 February 2008 4:55:42 pm
Minor changes to method definitions get rid of strict warnings:
Index: collaboration/ezapprove2/ezapprove2collaborationhandler.php
|
|
|
Bruce Morrison
Member since:
09 January 2008
Posts: 37
|
Wednesday 27 February 2008 5:01:59 pm
When an item is first created and caught by the workflow and is editied by the approver, the approver is prompted to place the item after publishing. This can be impossible as there is no information as to where the object was created.
I tracked this down to when the new draft is created from the original that the node assignments are note copied because they have a remote_id of 0 (I suspect because it's not been published)
The following patch manually copies the node assignments if the item has not been published and this "fixes' the issue.
Index: collaboration/ezapprove2/ezapprove2collaborationhandler.php
|
|
|
Bruce Morrison
Member since:
09 January 2008
Posts: 37
|
Wednesday 27 February 2008 5:09:15 pm
I suspect this is related the the previous item and possibility may be a an eZ issue. When an item is displayed in a collaboration preview using the plain view the location ("Placed in") is blank. You have to use the conten_version and not the content_object to get these to display.
I've added this to the extension but maybe it should go in the main eZ dist as it's most probably an issue with the shipped approve workflow
Index: design/standard/templates/node/view/plain.tpl
|
|
|
Bruce Morrison
Member since:
09 January 2008
Posts: 37
|
Wednesday 27 February 2008 8:25:58 pm
Typo in Constant
Index: eventtypes/event/ezapprove2/ezapprove2type.php
|
|
You need to be logged in to post messages in the forums. New users may register here.
