Revision a7a01525174557c057979613bcf0ec3dca7980b9
Committed on 16/10/2012 12:22 am by
Fabien Potencier <fabien.potencier@gmail.com> [GitHub Diff]
merged branch elnur/stop-using-alias (PR #25)
This PR was merged into the 2.0 branch.
Commits
-------
29dbd93 Use the original service ID instead of its alias.
Discussion
----------
Use the original service ID instead of its alias
`mailer` is just an alias and an app-specific service can use this name instead. To avoid collisions, use the original `swiftmailer.mailer` service ID.
---------------------------------------------------------------------------
by elnur at 2012-10-11T09:58:46Z
@fabpot, ping.
---------------------------------------------------------------------------
by fabpot at 2012-10-11T12:18:49Z
I don't see the point. The mailer service/alias is declared by this bundle, so it makes sense to use it.
---------------------------------------------------------------------------
by elnur at 2012-10-11T13:00:59Z
The point is that I want to use the `mailer` ID for my own mailer service that is built on top of Swiftmailer. It all works great — except this command because it relies on the `mailer` ID.
Why depend on an alias instead of the original service name? Is there a reason I don't see yet?
---------------------------------------------------------------------------
by elnur at 2012-10-16T06:58:21Z
So, @fabpot, what do you think?
